THRIFT-5924: UUID support for NodeTS#3331
Open
CJCombrink wants to merge 9 commits intoapache:masterfrom
Open
Conversation
- Not sure why this was needed or what changed but it works now
- Need confirmation on PR#3330 if this is the correct thing to do
CJCombrink
commented
Mar 6, 2026
CJCombrink
commented
Mar 6, 2026
lib/nodejs/test/server.crt
Outdated
Contributor
Author
There was a problem hiding this comment.
This was copied from the "test/keys" folder, I will try to use them from there instead and remove them here if I succeed
- Burden to have a copy of these for no real benefit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to add UUID support for NodeTS and NodeJS
Disclaimer: I don't develop in any one of these languages thus not sure if what I have done is correct
I still want to add nodejs and nodets in the cross tests but opening this so long in the hope for directed feedback about what is done. I also need to figure out what is needed to run these tests stand alone if anyone can assist it will be appreciated
[skip ci]anywhere in the commit message to free up build resources.